Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h@255 PS8, Line 255: // TODO: fix Z/M/ZM types and move to a function called from DCHECK > Is this something you planned to do soon? Yes, proper handling of Z/M coordinates in header is my next goal once this get merged. For the current functions it doesn't matter because all the info we get has a similar offset in geometries with Z/M coordinates, but for example to implement ST_MaxZ() and for proper esri<->ogc type enum mapping I need to look into it deeper. http://gerrit.cloudera.org:8080/#/c/23700/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/23700/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2720 PS8, Line 2720: # TODO: move these new tests to geospatial-esri-extra? > This doesn't seem hard to do. I wanted to do it in a separate patch to make the rebase of https://gerrit.cloudera.org/#/c/20602/ cleaner when the current patch is merged -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 05 Dec 2025 14:52:40 +0000 Gerrit-HasComments: Yes
