Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22092 )
Change subject: IMPALA-13531: (Addendum) CALCITE-5207 workaround ...................................................................... Patch Set 15: > Patch Set 15: > > I was able to reproduce your issue with q5 locally. > > So I have a lot of uncommitted changes in my local branch. I have your > changes (including this commit) on top of my changes in this branch: > > https://github.com/scarlin-cloudera/impala/tree/v5_downstream_match_for_david_base_wip > > Locally, I tested this branch, reverted this patch, and it seems that this > patch still does produce a cte without an exception. > > I think it was something changed in my local patch? I also tested lowering > the Calcite version down to 1.37 and it also worked ok. > > If we can hold off a little bit before pushing this, it might be good. It seems likely this won't be merged for at least a month or two. I'd like to wait until we update to Calcite 1.41 so I can use https://issues.apache.org/jira/browse/CALCITE-7111 in the frontend. -- To view, visit http://gerrit.cloudera.org:8080/22092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d19e83a3e2188a33d2d4a68b5afd3d457f4077c Gerrit-Change-Number: 22092 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 18:43:45 +0000 Gerrit-HasComments: No
