Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22092 )

Change subject: IMPALA-13531: (Addendum) CALCITE-5207 workaround
......................................................................


Patch Set 15:

Ok, yeah, this patch is still needed.  The following query fails even with the 
constant folding patch:

EXPLAIN with d1 as (
  select id_col from functional.date_tbl where
    cast('1998-08-04' as date) between date_col and (date_col + INTERVAL 14 
days)),
d2 as (
  select id_col from functional.date_tbl where
    cast('1998-08-04' as date) between date_col and (date_col + INTERVAL 14 
days))
select d1.id_col, d2.id_col from d1, d2;

Can you change the query in cte.test?  Once we do that, I'll look at this patch 
once more and we can get this merged without waiting for the rest of the CTE 
patch.

Thanks!


--
To view, visit http://gerrit.cloudera.org:8080/22092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d19e83a3e2188a33d2d4a68b5afd3d457f4077c
Gerrit-Change-Number: 22092
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Fri, 12 Dec 2025 16:15:53 +0000
Gerrit-HasComments: No

Reply via email to