Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22092 )
Change subject: IMPALA-13531: (Addendum) CALCITE-5207 workaround ...................................................................... Patch Set 15: > Patch Set 15: > > Ok, so I figured out which patch of mine fixes it. It's one that's already > uploaded: > > https://gerrit.cloudera.org/#/c/23723/ > > So that patch does constant folding, and the interval type goes away with > constant folding for q5. > > I know some queries do work with interval types already. I suppose this is > something specific with CTEs, since the stack trace is in the > Materializedview rule. > > I haven't looked at it too closely to determine if the rule would still > break if constant folding goes away. My guess is that it's still needed? > Can we change your test in cte.test to ensure constant folding doesn't happen? Have you checked whether https://gerrit.cloudera.org/c/22092/15/testdata/workloads/functional-query/queries/QueryTest/cte.test still fails? -- To view, visit http://gerrit.cloudera.org:8080/22092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d19e83a3e2188a33d2d4a68b5afd3d457f4077c Gerrit-Change-Number: 22092 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 19:54:36 +0000 Gerrit-HasComments: No
