Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1978 PS6, Line 1978: // Query didn't cross the resource limits, move to the end of the queue We still need to erase the event - now we have two copies of it so we've end up with exponential growth. http://gerrit.cloudera.org:8080/#/c/10415/6/be/src/service/impala-server.cc@1979 PS6, Line 1979: queries_by_timestamp_.emplace(ExpirationEvent{ nit: tabs -- To view, visit http://gerrit.cloudera.org:8080/10415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20 Gerrit-Change-Number: 10415 Gerrit-PatchSet: 6 Gerrit-Owner: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 15 Jun 2018 23:53:33 +0000 Gerrit-HasComments: Yes
