Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/10415 )
Change subject: IMPALA-6034: Add Cpu and scanned bytes limits per query
......................................................................
Patch Set 6:
Following diff prevents it from crashing immediately
-
query_state->GetCoordinator()->AggregateBackendsResourceUsage(&query_resource_usage);
+ Coordinator* coord = query_state->GetCoordinator();
+ if (coord == nullptr) {
+ queries_by_timestamp_.emplace(ExpirationEvent{
+ now + 1000L, expiration_event->query_id,
ExpirationKind::RESOURCE_LIMIT});
+ expiration_event = queries_by_timestamp_.erase(expiration_event);
+ continue;
+ }
+ coord->AggregateBackendsResourceUsage(&query_resource_usage);
--
To view, visit http://gerrit.cloudera.org:8080/10415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c6015e21da684bb9f33e236d71309dd4c178a20
Gerrit-Change-Number: 10415
Gerrit-PatchSet: 6
Gerrit-Owner: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Jun 2018 00:37:14 +0000
Gerrit-HasComments: No
