Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 )
Change subject: IMPALA-7046: introduce "global" debug_actions ...................................................................... Patch Set 6: (1 comment) This is a rebase but required fix up to remove the NDEBUG and do the empty() check like Tim added to the old code. http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.h File be/src/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.h@129 PS6, Line 129: WARN_UNUSED_RESULT gcc complains if this is at the end for a function definition, for some reason. So I put it here. -- To view, visit http://gerrit.cloudera.org:8080/10690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77663a539be18711a4f12c470ffd7474e3d69388 Gerrit-Change-Number: 10690 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Sat, 16 Jun 2018 00:04:14 +0000 Gerrit-HasComments: Yes
