Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 )
Change subject: IMPALA-7046: introduce "global" debug_actions ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/runtime/debug-options.cc File be/src/runtime/debug-options.cc: http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/runtime/debug-options.cc@58 PS6, Line 58: continue > I was thinking it could be possible for a global debug action to happen to I think all global debug actions have a size of exactly 2 components (separated by ':') and would be rejected at L39. I dont really have a strong preference against this as we can keep it to be future proof, in case we decide to expand the debug syntax further -- To view, visit http://gerrit.cloudera.org:8080/10690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77663a539be18711a4f12c470ffd7474e3d69388 Gerrit-Change-Number: 10690 Gerrit-PatchSet: 8 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Comment-Date: Tue, 19 Jun 2018 10:56:11 +0000 Gerrit-HasComments: Yes
