Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 )
Change subject: IMPALA-7046: introduce "global" debug_actions ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/runtime/debug-options.cc File be/src/runtime/debug-options.cc: http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/runtime/debug-options.cc@58 PS6, Line 58: continue > should we just return here instead(and on L55), since we don't expect this I was thinking it could be possible for a global debug action to happen to match up to here, so we should keep looking for the execnode action. http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.cc@310 PS6, Line 310: DebugActionImpl() > nit: DebugActionImpl Done http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.cc@335 PS6, Line 335: CK_GE(tokens.size > this wont work with "FAIL" given no probability Oops, messed that up when refactoring. Will fix and restest. http://gerrit.cloudera.org:8080/#/c/10690/6/be/src/util/debug-util.cc@374 PS6, Line 374: that should be 1 (I messed it up when refactoring). http://gerrit.cloudera.org:8080/#/c/10690/6/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/10690/6/common/thrift/ImpalaService.thrift@95 PS6, Line 95: SLEEP@<ms> > nit: SLEEP@<ms> Done http://gerrit.cloudera.org:8080/#/c/10690/6/common/thrift/ImpalaService.thrift@96 PS6, Line 96: JITTER@<ms > nit: JITTER@<ms> Done -- To view, visit http://gerrit.cloudera.org:8080/10690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77663a539be18711a4f12c470ffd7474e3d69388 Gerrit-Change-Number: 10690 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 20:53:41 +0000 Gerrit-HasComments: Yes
