Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23783 )
Change subject: WIP: IMPALA-14321: Add BINARY partition transform to Iceberg tables ...................................................................... Patch Set 5: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23783/5/be/src/exprs/iceberg-functions-test.cc File be/src/exprs/iceberg-functions-test.cc: http://gerrit.cloudera.org:8080/#/c/23783/5/be/src/exprs/iceberg-functions-test.cc@190 PS5, Line 190: void IcebergTruncatePartitionTransformTests::TestIncorrectWidthParameter<StringVal, IntVal>( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23783/5/be/src/exprs/iceberg-functions-test.cc@194 PS5, Line 194: StringVal ret_val = IcebergFunctions::TruncatePartitionTransform(ctx, input, IntVal(0), isBinary); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23783/5/be/src/exprs/iceberg-functions-test.cc@201 PS5, Line 201: ret_val = IcebergFunctions::TruncatePartitionTransform(ctx, input, IntVal(-1), isBinary); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23783/5/be/src/exprs/iceberg-functions-test.cc@208 PS5, Line 208: ret_val = IcebergFunctions::TruncatePartitionTransform(ctx, input, IntVal::null(), isBinary); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23783/5/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS5: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23783/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/23783/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@846 PS5, Line 846: ByteBuffer fieldByteBuffer = dataFile.rawPartitionFields(path_i).fieldValueAsByteBuffer(); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fd1ef382aa064dad55445dea00fbd39caeca1d3 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 14:47:49 +0000 Gerrit-HasComments: Yes
