Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23783 )
Change subject: WIP: IMPALA-14321: Add BINARY partition transform to Iceberg tables ...................................................................... Patch Set 8: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23783/8/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS8: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23783/8/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java File fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java: http://gerrit.cloudera.org:8080/#/c/23783/8/fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java@171 PS8, Line 171: case BINARY: return java.nio.ByteBuffer.wrap(((StringLiteral) literal).getBinValue()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23783/8/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/23783/8/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@775 PS8, Line 775: * https://github.com/apache/iceberg/blob/ccb8bc43/core/src/main/java/org/apache/iceberg/PartitionData.java#L119 line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/23783/8/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@792 PS8, Line 792: * https://github.com/apache/iceberg/blob/ccb8bc43/core/src/main/java/org/apache/iceberg/PartitionData.java#L132 line too long (116 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fd1ef382aa064dad55445dea00fbd39caeca1d3 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 18:08:28 +0000 Gerrit-HasComments: Yes
