Hello Zoltan Borok-Nagy, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23783
to look at the new patch set (#7).
Change subject: WIP: IMPALA-14321: Add BINARY partition transform to Iceberg
tables
......................................................................
WIP: IMPALA-14321: Add BINARY partition transform to Iceberg tables
With this change we add support for IDENTITY, TRUNCATE and BUCKET
partition transformation functions with binary parameter.
Testing:
- add binary tests to iceberg-functions-test.cc
- add binary partitioning columns to existing e2e tests
Todos left:
- ShowFilesStmt.java:161 is throwing exception with binary partiton
filtering expression
- partition pruning is not working (iceberg-partitioned-insert-*.test)
Change-Id: I5fd1ef382aa064dad55445dea00fbd39caeca1d3
---
M be/src/exec/file-metadata-utils.cc
M be/src/exprs/iceberg-functions-ir.cc
M be/src/exprs/iceberg-functions-test.cc
M be/src/exprs/iceberg-functions.h
M be/src/runtime/dml-exec-state.cc
M common/fbs/IcebergObjects.fbs
M common/function-registry/impala_functions.py
M fe/src/main/java/org/apache/impala/analysis/IcebergPartitionField.java
M fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/common/IcebergPredicateConverter.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v1.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-v2.test
M
testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test
17 files changed, 323 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/23783/7
--
To view, visit http://gerrit.cloudera.org:8080/23783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5fd1ef382aa064dad55445dea00fbd39caeca1d3
Gerrit-Change-Number: 23783
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
