Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 )
Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening ...................................................................... Patch Set 2: (2 comments) Some socketing concerns, sorry for not noticing them in the first run. http://gerrit.cloudera.org:8080/#/c/10747/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/10747/2/tests/shell/test_shell_commandline.py@621 PS2, Line 621: accept I think that this will wait forever by default if no one connects to it. setdefaulttimeout should be to set avoid this ("select" or something similar can be used too, but that will be more complex I guess). http://gerrit.cloudera.org:8080/#/c/10747/2/tests/shell/test_shell_commandline.py@624 PS2, Line 624: impala_shell.kill() : connection.close() These should be moved to a finally block to call them if there is an exception, for example from the assert. -- To view, visit http://gerrit.cloudera.org:8080/10747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd64632ded936d49fc404bcac75588dd7886be44 Gerrit-Change-Number: 10747 Gerrit-PatchSet: 2 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 19:52:34 +0000 Gerrit-HasComments: Yes
