Hello Philip Zeyliger, Csaba Ringhofer,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10747
to look at the new patch set (#3).
Change subject: IMPALA-7181: Fix flaky test
shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening
......................................................................
IMPALA-7181: Fix flaky test
shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening
test_shell_commandline.py::TestImpalaShell::test_socket_opening
uses netcat to listen to an ephmeral port to verify the expected
socket opening behavior of impala-shell.
This port number is fixed to 42000. When this port happens to
be used by another outbound socket, this test will fail.
This change refactors the test to use socket.bind(). The port used
in this test is no longer fixed and will be picked automatically.
This change also adds the proper cleanup logics to the various
subprocess.Popen objects used in the test.
Change-Id: Idd64632ded936d49fc404bcac75588dd7886be44
---
M tests/shell/test_shell_commandline.py
1 file changed, 35 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/10747/3
--
To view, visit http://gerrit.cloudera.org:8080/10747
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd64632ded936d49fc404bcac75588dd7886be44
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Vincent Tran <[email protected]>
