Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 )
Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10747/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/10747/3/tests/shell/test_shell_commandline.py@626 PS3, Line 626: impala_shell.kill() This can actually also throw an exception, if the process already exited for some reason. http://gerrit.cloudera.org:8080/#/c/10747/3/tests/shell/test_shell_commandline.py@627 PS3, Line 627: connection.close() connection should be None checked. -- To view, visit http://gerrit.cloudera.org:8080/10747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd64632ded936d49fc404bcac75588dd7886be44 Gerrit-Change-Number: 10747 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 20:59:49 +0000 Gerrit-HasComments: Yes
