Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23929 )

Change subject: IMPALA-14541: Remove deprecated CalciteJniFrontend class
......................................................................


Patch Set 3:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java
File 
java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java:

http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@109
PS3, Line 109:     CalciteRelNodeConverter relNodeConverter = new 
CalciteRelNodeConverter(analysisResult);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
File 
java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java:

http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@365
PS3, Line 365:           (CalciteAnalysisResult) ptb.parseAndAnalyze(query, 
feFixture_.createAnalysisCtx(),
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3797acf0f23da4f94098e2f8f5f7aa378c9ae91a
Gerrit-Change-Number: 23929
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Mon, 02 Feb 2026 19:15:02 +0000
Gerrit-HasComments: Yes

Reply via email to