Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23929 )

Change subject: IMPALA-14541: Remove deprecated CalciteJniFrontend class
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23929/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23929/5//COMMIT_MSG@19
PS5, Line 19: One minor change also in this commit: The Tpcds test was moved to 
the
            : planner directory to be more consistent with the other tests.
> Nit: As a curiosity: Why standardize on org.apache.impala.planner rather th
Moved the tests to calcite/planner


http://gerrit.cloudera.org:8080/#/c/23929/5/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java
File 
java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java:

http://gerrit.cloudera.org:8080/#/c/23929/5/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@375
PS5, Line 375:   private static class ReduceShuttleObjects {
> This is not really related to this change and doesn't need to happen in thi
filed IMPALA-14723



--
To view, visit http://gerrit.cloudera.org:8080/23929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3797acf0f23da4f94098e2f8f5f7aa378c9ae91a
Gerrit-Change-Number: 23929
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 04 Feb 2026 23:39:15 +0000
Gerrit-HasComments: Yes

Reply via email to