Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23929 )
Change subject: IMPALA-14541: Remove deprecated CalciteJniFrontend class ...................................................................... Patch Set 4: (2 comments) Modified FrontendTestBase so that the new parseAndAnalyze is also protected and made the appropriate fix in TestReduceExprShuttle http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java: http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestCalciteStats.java@109 PS3, Line 109: CalciteRelNodeConverter relNodeConverter = > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23929/3/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@365 PS3, Line 365: (CalciteAnalysisResult) ptb.parseAndAnalyze(query, > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/23929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3797acf0f23da4f94098e2f8f5f7aa378c9ae91a Gerrit-Change-Number: 23929 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 01:39:29 +0000 Gerrit-HasComments: Yes
