Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844: Support setting DBPROPERTIES ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/23905/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23905/12//COMMIT_MSG@14 PS12, Line 14: nit: you could mention about testing here http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java: http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java@22 PS12, Line 22: import com.google.common.base.Preconditions; : import org.apache.impala.authorization.AuthorizationChecker; : import org.apache.impala.authorization.AuthorizationFactory; nit: unused imports. Also at L#28,31,32 http://gerrit.cloudera.org:8080/#/c/23905/12/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23905/12/tests/custom_cluster/test_events_custom_configs.py@1882 PS12, Line 1882: def run_test(alter_dbproperties_in_impala): I think it is better to add a new test to verify the alter database set properties functionality. -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 12 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 19:23:13 +0000 Gerrit-HasComments: Yes
