Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844: Support setting DBPROPERTIES ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/23905/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23905/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@8394 PS9, Line 8394: !params.isSetColumn_name()); : tTableName.get().setDb_name(params.db); : catalogOpTracker_.increment(ddlRequest, tTableName); > nit: Could we move params.getSet_dbproperties_params() to the case of SET_D Done http://gerrit.cloudera.org:8080/#/c/23905/9/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@8424 PS9, Line 8424: Db db = catalog_.getDb(dbName); : if (db == null) { : throw new CatalogException("Database: " + dbName + " does not exist."); : } : tryLock(db, "altering the comment", catalogTimeline); : // Get a new catalog version to assign to the database being altered. : long newCatalogVersion = catalog_.incrementAndGetCatalogVersion(); : catalog_.getLock().writeLock().unlock(); : try { : Database msDb = db.getMetaStoreDb().deepCopy(); : a > nit: Would it be better to use a switch statement here to deal with various Done -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 10 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 09:30:45 +0000 Gerrit-HasComments: Yes
