Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23946 )
Change subject: IMPALA-14623: Optimize memory usage for Iceberg file path hashes ...................................................................... Patch Set 1: I generated some code for micro-benchmarking and got these results: ================================================================= Hash128 Performance Micro-Benchmark for Iceberg File Path Hashing ================================================================= Test Configuration: Warmup iterations: 50000 Benchmark iterations: 5000000 Test paths: 5 Total operations per test: 25000000 Running: Murmur3 + ByteBuffer... Running: Murmur3 + Manual Loop... Running: XXHash (OpenHFT)... ================================================================= SUMMARY ================================================================= Approach Time (ms) Throughput Speedup ----------------------------------------------------------------- Murmur3 + ByteBuffer 19,962.11 1,252,372/s 1.00x Murmur3 + Manual Loop 16,345.14 1,529,507/s 1.22x XXHash (OpenHFT) 1,620.90 15,423,567/s 12.32x ================================================================= I suppose we dont need the script file, and I will address the rest of the comments in the subsequent patch. Let me know if there are any other concerns. -- To view, visit http://gerrit.cloudera.org:8080/23946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0de793de2434dae3b60c3aa4f87dba203eee3c1 Gerrit-Change-Number: 23946 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 13:38:31 +0000 Gerrit-HasComments: No
