Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23946 )
Change subject: IMPALA-14623: Optimize memory usage for Iceberg file path hashes ...................................................................... Patch Set 2: (5 comments) Thanks for the review http://gerrit.cloudera.org:8080/#/c/23946/1/be/src/util/thash128-util.h File be/src/util/thash128-util.h: http://gerrit.cloudera.org:8080/#/c/23946/1/be/src/util/thash128-util.h@20 PS1, Line 20: #include "gen-cp > Unnecessary include of 'tuple'. Done http://gerrit.cloudera.org:8080/#/c/23946/1/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/23946/1/common/thrift/CatalogObjects.thrift@667 PS1, Line 667: XXH128 > If we already change things, we should also switch to XXH3. Done http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@660 PS2, Line 660: // Represents a 128-bit hash value (Murmur3 hash of file path) Missed changing the Murmur3 to XXH128 here. Will do it in the next patch. http://gerrit.cloudera.org:8080/#/c/23946/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/23946/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@748 PS1, Line 748: } : : /** : * Converts Flat Buffer file f > ByteBuffer adds unnecessary allocation overhead. I think we should optimize Done, but we dont have this xx_h3() in openhft version 0.16. So we are using xx128(), the 128-bit hash. http://gerrit.cloudera.org:8080/#/c/23946/1/fe/src/test/java/org/apache/impala/util/Hash128Test.java File fe/src/test/java/org/apache/impala/util/Hash128Test.java: http://gerrit.cloudera.org:8080/#/c/23946/1/fe/src/test/java/org/apache/impala/util/Hash128Test.java@20 PS1, Line 20: a > nit: we prefer non-wildcard imports Done -- To view, visit http://gerrit.cloudera.org:8080/23946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0de793de2434dae3b60c3aa4f87dba203eee3c1 Gerrit-Change-Number: 23946 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 17:50:50 +0000 Gerrit-HasComments: Yes
