Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23946 )
Change subject: IMPALA-14623: Optimize memory usage for Iceberg file path hashes ...................................................................... Patch Set 2: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@669 PS2, Line 669: 1: optional map<THash128, THdfsFileDesc> path_hash_to_data_file_without_deletes Changing type of field 'path_hash_to_data_file_without_deletes' from map<string,THdfsFileDesc> to map<THash128,THdfsFileDesc> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@670 PS2, Line 670: 2: optional map<THash128, THdfsFileDesc> path_hash_to_data_file_with_deletes Changing type of field 'path_hash_to_data_file_with_deletes' from map<string,THdfsFileDesc> to map<THash128,THdfsFileDesc> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@671 PS2, Line 671: 3: optional map<THash128, THdfsFileDesc> path_hash_to_position_delete_file Changing type of field 'path_hash_to_position_delete_file' from map<string,THdfsFileDesc> to map<THash128,THdfsFileDesc> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@672 PS2, Line 672: 4: optional map<THash128, THdfsFileDesc> path_hash_to_equality_delete_file Changing type of field 'path_hash_to_equality_delete_file' from map<string,THdfsFileDesc> to map<THash128,THdfsFileDesc> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade -- To view, visit http://gerrit.cloudera.org:8080/23946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0de793de2434dae3b60c3aa4f87dba203eee3c1 Gerrit-Change-Number: 23946 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 17:38:24 +0000 Gerrit-HasComments: Yes
