Arnab Karmakar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23946 )

Change subject: IMPALA-14623: Optimize memory usage for Iceberg file path hashes
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift
File common/thrift/CatalogObjects.thrift:

http://gerrit.cloudera.org:8080/#/c/23946/2/common/thrift/CatalogObjects.thrift@660
PS2, Line 660: // Represents a 128-bit hash value (XXH128 hash of file path)
> Missed changing the Murmur3 to XXH128 here. Will do it in the next patch.
Done


http://gerrit.cloudera.org:8080/#/c/23946/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/23946/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@737
PS2, Line 737:    * Use ContentFile path to generate 128-bit XXH128 hash as map 
key, cached in memory
> Murmur -> XXH128 missed
Done



--
To view, visit http://gerrit.cloudera.org:8080/23946
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0de793de2434dae3b60c3aa4f87dba203eee3c1
Gerrit-Change-Number: 23946
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Sat, 07 Feb 2026 08:57:44 +0000
Gerrit-HasComments: Yes

Reply via email to