Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23800 )
Change subject: IMPALA-14555: Add Iceberg support for SHOW PARTITIONS WHERE ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/23800/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23800/5//COMMIT_MSG@13 PS5, Line 13: manifest-based file/partition fil > nit: "manifest-base file/partition filtering", or "metadata-based file/part Done http://gerrit.cloudera.org:8080/#/c/23800/5//COMMIT_MSG@20 PS5, Line 20: rted. Instead query the metadata : table directly: ```SELECT `partition` FROM functional_parquet.iceberg_par > iceberg_partitioned is in the functional_parquet database. Also, "partition Thanks for noticing this fine detail, Id just simply written this without much thoughts. We are now using: SELECT `partition` FROM functional_parquet.iceberg_partitioned.`partitions` WHERE `partition`.action = 'click'; http://gerrit.cloudera.org:8080/#/c/23800/5/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java: http://gerrit.cloudera.org:8080/#/c/23800/5/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java@66 PS5, Line 66: BetweenPredicate betweenPredicate = ( > This also makes it possible to use BETWEEN in DROP PARTITION statements, ri Done http://gerrit.cloudera.org:8080/#/c/23800/5/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java@65 PS5, Line 65: if (expr instanceof BetweenPredicate) { : BetweenPredicate betweenPredicate = (BetweenPredicate) expr; : return rewrite(betweenPredicate); : } : if (expr instanceof BinaryPredicate) { : BinaryPredicate binaryPredicate = (BinaryPredicate) expr; : > I think it would be cleaner to follow the same pattern you see in this meth Done http://gerrit.cloudera.org:8080/#/c/23800/5/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23800/5/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@260 PS5, Line 260: * -- Not supported due to upper() function : * Instead query the metadata table > This query is invalid, see my other comment. Done -- To view, visit http://gerrit.cloudera.org:8080/23800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c0ee4d171ae939770725d89dc504e13f82a7688 Gerrit-Change-Number: 23800 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 17:48:55 +0000 Gerrit-HasComments: Yes
