Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23800 )
Change subject: IMPALA-14555: Add Iceberg support for SHOW PARTITIONS WHERE ...................................................................... Patch Set 9: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23800/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23800/9//COMMIT_MSG@21 PS9, Line 21: table directly: ```SELECT `partition` FROM functional_parquet.iceberg_partitioned.`partitions` It'd be nice to make this a little more readable in the commit, we don't have markdown formatting most places. http://gerrit.cloudera.org:8080/#/c/23800/9/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test: http://gerrit.cloudera.org:8080/#/c/23800/9/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test@419 PS9, Line 419: # Test BETWEEN predicate in DROP PARTITION This looks like new functionality for DROP PARTITION as well. Can you call that out in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/23800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c0ee4d171ae939770725d89dc504e13f82a7688 Gerrit-Change-Number: 23800 Gerrit-PatchSet: 9 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 19:48:29 +0000 Gerrit-HasComments: Yes
