Arnab Karmakar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23800 )

Change subject: IMPALA-14555: Add Iceberg support for SHOW PARTITIONS WHERE
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23800/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23800/7//COMMIT_MSG@22
PS7, Line 22: upper(`partition`.action) =
> To demonstrate function usage, it should be upper(`partition`.action) = 'CL
Done


http://gerrit.cloudera.org:8080/#/c/23800/7/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/23800/7/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@263
PS7, Line 263: upper(`partition`.action) =
> Should be upper(`partition`.action) = 'CLICK' for demonstrating purposes.
Done


http://gerrit.cloudera.org:8080/#/c/23800/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test:

http://gerrit.cloudera.org:8080/#/c/23800/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-drop-partition.test@497
PS7, Line 497: AnalysisException: $DATABASE.bucket() unknown for database 
$DATABASE
> Is it possible to get a better error message for this case?
Ive pasted the whole exception message now, is that OK?



--
To view, visit http://gerrit.cloudera.org:8080/23800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c0ee4d171ae939770725d89dc504e13f82a7688
Gerrit-Change-Number: 23800
Gerrit-PatchSet: 8
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 11 Feb 2026 17:15:48 +0000
Gerrit-HasComments: Yes

Reply via email to