Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/23900/9/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/23900/9/common/thrift/ImpalaService.thrift@1028 PS9, Line 1028: USE_CALCITE_PLANNER = 191 // Removed We have REMOVED_QUERY_OPT_FN, can we use that on this option in query-options.h? That's what seems to have been done to others marked with "// Removed". http://gerrit.cloudera.org:8080/#/c/23900/9/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23900/9/common/thrift/Query.thrift@a1164 PS9, Line 1164: nit: unnecessary whitespace change http://gerrit.cloudera.org:8080/#/c/23900/9/tests/custom_cluster/test_calcite_planner.py File tests/custom_cluster/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/23900/9/tests/custom_cluster/test_calcite_planner.py@41 PS9, Line 41: @CustomClusterTestSuite.with_args(start_args="--env_vars=USE_CALCITE_PLANNER=true") Does this env_var still do something? It shows up a few places, can we clean it up? If we no longer need to specify additional options to enable USE_CALCITE_PLANNER, these could also be moved out of custom cluster tests. -- To view, visit http://gerrit.cloudera.org:8080/23900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823 Gerrit-Change-Number: 23900 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 10 Feb 2026 21:46:59 +0000 Gerrit-HasComments: Yes
