Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/23900/10/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23900/10/be/src/service/query-options.h@377 PS10, Line 377: REMOVED_QUERY_OPT_FN(use_calcite_planner, USE_CALCITE_PLANNER) \ : QUERY_OPT_FN(json_binary_format, JSON_BINARY_FORMAT, TQueryOptionLevel::REGULAR) \ > REMOVED_QUERY_OPT_FN doesn't take a third arg, so we'll need to remove the Ugh...as you can prolly tell, I didn't compile before submitting because I thought this was such a simple change. My bad :( Fixed now (and compiled :) ) http://gerrit.cloudera.org:8080/#/c/23900/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23900/10/fe/src/main/java/org/apache/impala/service/Frontend.java@3800 PS10, Line 3800: throw new TransactionException(e.getMessage()); : } finally { : // Call KuduTransaction.close() explicitly to stop sending automatic : // keepalive messages by the 'txn' handle. : txn.close(); : } : } : } : : private CompilerFactory getCompilerFactory(TPlannerType plannerType) { : switch (plannerType) { : case ORIGINAL: : LOG.info("Using Original Planner."); : return ORIGINAL_COMPILER_FACTORY; : case CALCITE: : if (CALCITE_COMPILER_FACTORY == null) { : LOG.info("Could not find Calcite planner."); : throw new RuntimeException("Could not find Calcite Planner"); : } : LOG.info("Using Calcite Planner."); : return CALCITE_COMPILER_FACTORY; : default: : throw new RuntimeException("Unknown planner type: [" + plannerType + "]"); : } : } : > When https://gerrit.cloudera.org/#/c/23935/ goes in, this code will change. Noted and merged (and changed slightly) http://gerrit.cloudera.org:8080/#/c/23900/9/tests/custom_cluster/test_calcite_planner.py File tests/custom_cluster/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/23900/9/tests/custom_cluster/test_calcite_planner.py@41 PS9, Line 41: @CustomClusterTestSuite.with_args(start_args="--env_vars=USE_CALCITE_PLANNER=true") > We can deal with it separately. But the other cases don't need to be custom Got it, that makes sense. I created a new test under query_tests. In that test, I have all the same tests and they just use the query options. I did keep this file to test the server flag and only kept the one test. Does it make sense to do it this way? Or should I minimize the custom cluster test even more? -- To view, visit http://gerrit.cloudera.org:8080/23900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823 Gerrit-Change-Number: 23900 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 12 Feb 2026 18:11:55 +0000 Gerrit-HasComments: Yes
