Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/23900/10/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23900/10/be/src/service/query-options.h@377 PS10, Line 377: REMOVED_QUERY_OPT_FN(use_calcite_planner, USE_CALCITE_PLANNER, \ : TQueryOptionLevel::ADVANCED) \ REMOVED_QUERY_OPT_FN doesn't take a third arg, so we'll need to remove the TQueryOptionLevel::ADVANCED. http://gerrit.cloudera.org:8080/#/c/23900/10/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23900/10/fe/src/main/java/org/apache/impala/service/Frontend.java@3800 PS10, Line 3800: @Nullable : private CompilerFactory getCompilerFactory(TPlannerType plannerType) { : switch (plannerType) { : case ORIGINAL: : return new CompilerFactoryImpl(); : case CALCITE: { : try { : CompilerFactory calciteFactory = (CompilerFactory) Class.forName( : "org.apache.impala.calcite.service." + : "CalciteCompilerFactory").newInstance(); : if (calciteFactory != null) { : LOG.info("Found Calcite Planner, using it."); : return calciteFactory; : } else { : LOG.info("Could not find Calcite planner."); : throw new RuntimeException("Could not find Calcite Planner"); : } : } catch (Exception e) { : LOG.info("Could not find Calcite planner: " + e); : throw new RuntimeException(e); : } : } : default: : throw new RuntimeException("Unknown planner type: [" + plannerType + "]"); : } : } When https://gerrit.cloudera.org/#/c/23935/ goes in, this code will change. -- To view, visit http://gerrit.cloudera.org:8080/23900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823 Gerrit-Change-Number: 23900 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 17:25:03 +0000 Gerrit-HasComments: Yes
