Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10690 )
Change subject: IMPALA-7046: introduce "global" debug_actions ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/10690/8/be/src/util/debug-util.cc File be/src/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/10690/8/be/src/util/debug-util.cc@318 PS8, Line 318: if (parse_result != StringParser::PARSE_SUCCESS || > It turns into a status at lines 356/367. Are you looking for something more Ah no, never mind. http://gerrit.cloudera.org:8080/#/c/10690/8/be/src/util/debug-util.cc@323 PS8, Line 323: *should_execute = rand() < probability * (RAND_MAX + 1L); > Not really. I think I'll change the one below to rand() which is what I mea WFM http://gerrit.cloudera.org:8080/#/c/10690/8/be/src/util/debug-util.cc@339 PS8, Line 339: if (cmd.compare("SLEEP") == 0) { > yeah, I do generally disklike operator overloading, though don't feel too s Seems fine. http://gerrit.cloudera.org:8080/#/c/10690/8/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/10690/8/common/thrift/ImpalaService.thrift@91 PS8, Line 91: // 2. Global actions > Yeah, let's defer that. I'm not sure there are that many more commands we n Yeah I agree it's not worth it now. -- To view, visit http://gerrit.cloudera.org:8080/10690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77663a539be18711a4f12c470ffd7474e3d69388 Gerrit-Change-Number: 10690 Gerrit-PatchSet: 8 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 22:19:38 +0000 Gerrit-HasComments: Yes
