Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 13: (8 comments) http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@139 PS11, Line 139: nse_size > nit: "initially" Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@139 PS11, Line 139: > nit: add a period. Its a part of the same sentence right http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@159 PS11, Line 159: } : : /** : * > This can be merged into the constructor of InFlightOperation. Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@192 PS11, Line 192: record.setCatalog_op_name(catalogOpName); : record.setTarget_name(targetName); : record.setUser(user); : record.setClient_ip(clientIp); : record.setCoordinator_hostname(coordinator); : record.setDetails(details); : } : : private void archiveRecord(TUniqueId queryId, String errorMsg) { : if (queryId == null) return; : RpcKey key = new RpcKey(queryId); : InFlightOperation operation = inFlightOperations_.remove(key); : if (operation == null) { : LOG.error("Null operation for query {}", TUniqueIdUtil.PrintId(queryId)); : return; : } : T > If we return the record in addRecord(), maybe we don't need these since inc Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@318 PS11, Line 318: TUniqueId queryId = req.getHeader().getQuery_id(); > Is it true that if queryId is not null, we can always find the inflight ope Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@369 PS11, Line 369: // Set current timeline if available > Same in this method and the method for TUpdateCatalogRequest. Please check Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java@332 PS11, Line 332: // Operation details will be set later in increment() > We can let addRecord() returns the record and later use it directly in sett Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java@336 PS11, Line 336: he > Why do we need an array here? responseHolder is used inside a lambda and passed to execAndSerialize(). If we want to modify a variable inside lambda and access it outside we need to use a workaround like array. In this case we are setting the response inside lambda and accessing it outside the lambda. -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 13 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 27 Feb 2026 06:57:59 +0000 Gerrit-HasComments: Yes
