Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 13: (7 comments) Thanks for updating the patch! It looks pretty good now. I just have some minor comments. http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@107 PS13, Line 107: * and its associated EventSequence for real-time timeline tracking. nit: Please add a comment to mention that TCatalogOpRecord also has a timeline but it's in TEventSequence type. So we need to track the original EventSequence instance separately. http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@151 PS13, Line 151: // Set request size nit: remove such obvious comments. http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@205 PS13, Line 205: LOG.error("Null operation for query {}", TUniqueIdUtil.PrintId(queryId)); nit: Let's make this more clear, e.g. "Failed to archive the in-flight operation of query {} since it's missing". http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@238 PS13, Line 238: TUniqueId queryId = ddlRequest.getHeader().getQuery_id(); nit: If queryId is null, updateRecordFields() does nothing. We can actually return fast here. http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@280 PS13, Line 280: TUniqueId queryId = req.getHeader().getQuery_id(); nit: return fast here when queryId == null. http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@318 PS13, Line 318: TUniqueId queryId = req.getHeader().getQuery_id(); nit: return fast when queryId == null. http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java@336 PS11, Line 336: he > responseHolder is used inside a lambda and passed to execAndSerialize(). If Actually, we don't need to hold the response here. In the check on L345, we just need if (record != null && result != null && result.length > 0) { -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 13 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2026 11:18:42 +0000 Gerrit-HasComments: Yes
