Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 14: (10 comments) http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@92 PS13, Line 92: return queryId_.equals(key.queryId_) && threadId_ == key.threadId_; : } : > I think we can remove these null branches since all the callsites on the co Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@107 PS13, Line 107: * during operation execution. > nit: Please add a comment to mention that TCatalogOpRecord also has a timel Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@151 PS13, Line 151: record.setRequest_size_bytes(requestSizeBytes); > nit: remove such obvious comments. Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@205 PS13, Line 205: "it's missing", TUniqueIdUtil.PrintId(queryId)); > nit: Let's make this more clear, e.g. "Failed to archive the in-flight oper Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@238 PS13, Line 238: TUniqueId queryId = ddlRequest.getHeader().getQuery_id(); > nit: If queryId is null, updateRecordFields() does nothing. We can actually Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@280 PS13, Line 280: > nit: return fast here when queryId == null. Done http://gerrit.cloudera.org:8080/#/c/23811/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@318 PS13, Line 318: TCatalogServiceRequestHeader header = req.getHeader(); > nit: return fast when queryId == null. Done http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23811/11/fe/src/main/java/org/apache/impala/service/JniCatalog.java@336 PS11, Line 336: ze > Actually, we don't need to hold the response here. In the check on L345, we Oh right thanks, we are just using the serialized byte length. Removed it now. http://gerrit.cloudera.org:8080/#/c/23811/13/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/23811/13/tests/webserver/test_web_pages.py@1274 PS13, Line 1274: assert "response_size_bytes" in detail_data, "response_size_bytes field missing" : : # Verify the fields contain actual data : assert len(detail_data["timeline"]) > 0, "timeline should not be empty" : assert detail_data["request_size_bytes"] > 0, \ : "request_size_bytes should be positive" : assert detail_data["response_size_bytes"] > 0, \ : "response_size_bytes should be positive" : : # Verify timeline is formatted text (pre-formatted on server side) : timeline_str = detail_data["timeline"] : assert isinstance(timeline_str, str), "timeline should be a formatted string" : : # Check for expected timeline format from RuntimeProfile : assert "Catalog Server Operation:" in timeline_str, \ : "timeline should have the operation name" : # Check that it contains typical timeline events : assert ("Got" in timeline_str or "DDL" in timeline_str > Wrong indentation here. Done http://gerrit.cloudera.org:8080/#/c/23811/13/tests/webserver/test_web_pages.py@1293 PS13, Line 1293: > nit: Remove useless logging. The logs are only visible when the test fails. Done -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 14 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 06:57:06 +0000 Gerrit-HasComments: Yes
