Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24042 )
Change subject: IMPALA-14592: Read Row Lineage of Iceberg tables ...................................................................... Patch Set 3: (4 comments) Just a first look, I only left a few small nitpicks. http://gerrit.cloudera.org:8080/#/c/24042/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24042/3//COMMIT_MSG@17 PS3, Line 17: of nit: or http://gerrit.cloudera.org:8080/#/c/24042/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24042/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@317 PS3, Line 317: 2147483540 Magic number. Is this constant defined in Iceberg library? http://gerrit.cloudera.org:8080/#/c/24042/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@320 PS3, Line 320: 2147483539 Magic number. http://gerrit.cloudera.org:8080/#/c/24042/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/24042/3/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@198 PS3, Line 198: of nit: delete duplicate 'of' -- To view, visit http://gerrit.cloudera.org:8080/24042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b1076b25c9e7a0a6c9428b24abc986f5382c71 Gerrit-Change-Number: 24042 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 09 Mar 2026 15:56:32 +0000 Gerrit-HasComments: Yes
