Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24042 )
Change subject: IMPALA-14592: Read Row Lineage of Iceberg tables ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Nice patch, Zoltan! http://gerrit.cloudera.org:8080/#/c/24042/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24042/3//COMMIT_MSG@28 PS3, Line 28: _file_row_id What about _FILE_ROW_ID, similarly with fully uppercase words like the virtual columns? Is there any consideration about using lowercase words? http://gerrit.cloudera.org:8080/#/c/24042/3/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: http://gerrit.cloudera.org:8080/#/c/24042/3/common/fbs/IcebergObjects.fbs@52 PS3, Line 52: first_row_id : long; it could be -1 by default as it is the sentinel value -- To view, visit http://gerrit.cloudera.org:8080/24042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b1076b25c9e7a0a6c9428b24abc986f5382c71 Gerrit-Change-Number: 24042 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:58:58 +0000 Gerrit-HasComments: Yes
