Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24041 )

Change subject: IMPALA-14583: Support partial RPC dispatch for Iceberg tables
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24041/2/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/24041/2/tests/custom_cluster/test_local_catalog.py@791
PS2, Line 791:                        "functional.alltypestiny".format(tbl))
             :     exception = self.execute_query_expect_failure(
> Was almost a minute, and now less than 25s. Is that ok ?
I would still prefer it to be faster if the test can still work with it, but I 
can let it go


http://gerrit.cloudera.org:8080/#/c/24041/2/tests/custom_cluster/test_local_catalog.py@798
PS2, Line 798:     assert err in str(exception)
             :     self.assert_catalogd_log_contains("ERROR", err)
> It's needed becase the latest insert statements themselves trigger metadata
ack



--
To view, visit http://gerrit.cloudera.org:8080/24041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f2c058b7cc8efc15bac9fe0e91baadbb7b92cbb
Gerrit-Change-Number: 24041
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 09 Mar 2026 20:52:01 +0000
Gerrit-HasComments: Yes

Reply via email to