Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24041 )
Change subject: IMPALA-14583: Support partial RPC dispatch for Iceberg tables ...................................................................... Patch Set 3: (3 comments) Thanks for fixing this! Just have some minor comments. http://gerrit.cloudera.org:8080/#/c/24041/3/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/24041/3/tests/custom_cluster/test_local_catalog.py@726 PS3, Line 726: nit: please fix the idention, e.g. moving all parameters to the next line and use 4 spaces indention def _assert_iceberg_pagination_logs( self, query_id, tbl, files_per_page, total_files, num_requests=r"\d+"): http://gerrit.cloudera.org:8080/#/c/24041/3/tests/custom_cluster/test_local_catalog.py@745 PS3, Line 745: r"across {3} requests".format(query_id, total_files, tbl, num_requests)) nit: add a blank line after this BTW, moving this method down to just before the iceberg tests where it's used is more friendly for code readers. http://gerrit.cloudera.org:8080/#/c/24041/3/tests/custom_cluster/test_local_catalog.py@821 PS3, Line 821: query_id = re.search(r"Query \(id=(.*)\):", res.runtime_profile).group(1) nit: we can use parse_query_id() directly https://github.com/apache/impala/blame/c601f44281805e421d2ce401729a703e5b16345b/tests/util/query_profile_util.py#L75 -- To view, visit http://gerrit.cloudera.org:8080/24041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f2c058b7cc8efc15bac9fe0e91baadbb7b92cbb Gerrit-Change-Number: 24041 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2026 12:52:17 +0000 Gerrit-HasComments: Yes
