Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24041 )
Change subject: IMPALA-14583: Support partial RPC dispatch for Iceberg tables ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24041/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24041/3//COMMIT_MSG@16 PS3, Line 16: This patch implements : offset-based pagination to allow catalogd to truncate the response at : any point in the file list, not just at partition boundaries. Do we also change the corresponding implementation for HdfsTable? http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@104 PS3, Line 104: import org.apache.impala.thrift.TIcebergContentFileStore; nit: unused import http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1241 PS3, Line 1241: // Count files in initial response nit: this comment corresponds to L1246. Maybe move it down. http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1286 PS3, Line 1286: /** : * Count total files in TIcebergContentFileStore. : */ nit: stale comment? -- To view, visit http://gerrit.cloudera.org:8080/24041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f2c058b7cc8efc15bac9fe0e91baadbb7b92cbb Gerrit-Change-Number: 24041 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:32:40 +0000 Gerrit-HasComments: Yes
