Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24075 )

Change subject: IMPALA-14789: Modify some tests for Calcite planner
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test
File testdata/workloads/functional-query/queries/QueryTest/subquery.test:

http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1108
PS1, Line 1108: ---- CALCITE_PLANNER_CATCH: ANY_OF
What does the ANY_OF do?


http://gerrit.cloudera.org:8080/#/c/24075/1/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/24075/1/tests/common/skip.py@139
PS1, Line 139:   is_calcite_planner = pytest.mark.skipif(True,
             :       reason="Disabled for Calcite Planner")
Can we go ahead and make this it's own SkipIfCalcite class with a couple fields 
for different reasons?



--
To view, visit http://gerrit.cloudera.org:8080/24075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc0982fe2ece5323cfc77ee8aee4c55bac6062f
Gerrit-Change-Number: 24075
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 12 Mar 2026 17:28:57 +0000
Gerrit-HasComments: Yes

Reply via email to