Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24075 )

Change subject: IMPALA-14789: Modify some tests for Calcite planner
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24075/2/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/24075/2/tests/common/skip.py@296
PS2, Line 296: class SkipIfCalcite:
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/24075/2/tests/custom_cluster/test_lineage.py
File tests/custom_cluster/test_lineage.py:

http://gerrit.cloudera.org:8080/#/c/24075/2/tests/custom_cluster/test_lineage.py@29
PS2, Line 29: from tests.common.skip import SkipIfFS, SkipIf, SkipIfCalcite
flake8: F401 'tests.common.skip.SkipIf' imported but unused



--
To view, visit http://gerrit.cloudera.org:8080/24075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cc0982fe2ece5323cfc77ee8aee4c55bac6062f
Gerrit-Change-Number: 24075
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Fri, 13 Mar 2026 15:47:41 +0000
Gerrit-HasComments: Yes

Reply via email to