Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24075 )
Change subject: IMPALA-14789: Modify some tests for Calcite planner ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test File testdata/workloads/functional-query/queries/QueryTest/subquery.test: http://gerrit.cloudera.org:8080/#/c/24075/1/testdata/workloads/functional-query/queries/QueryTest/subquery.test@1108 PS1, Line 1108: ---- CALCITE_PLANNER_CATCH: ANY_OF > What does the ANY_OF do? Sigh, I cheated a bit here... ANY_OF allows you to put multiple errors and it will be ok if any one of them succeeds. I saw this used with NO_ERROR. The reason I used it here: You cannot leave a blank section of CATCH. As coded, you also cannot have a CATCH section with NO_ERROR...I suppose that kinda makes sense? Before this change, there would be no reason to have a CATCH section with no error. So I got a little lazy because i didn't consider this a major feature and just used something that worked with minimal code I can go ahead and file a Jira for this, or fix it here if you don't find this acceptable. http://gerrit.cloudera.org:8080/#/c/24075/1/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/24075/1/tests/common/skip.py@139 PS1, Line 139: : > Can we go ahead and make this it's own SkipIfCalcite class with a couple fi Done http://gerrit.cloudera.org:8080/#/c/24075/2/tests/custom_cluster/test_lineage.py File tests/custom_cluster/test_lineage.py: http://gerrit.cloudera.org:8080/#/c/24075/2/tests/custom_cluster/test_lineage.py@29 PS2, Line 29: from tests.common.skip import SkipIfFS, SkipIf, SkipIfCalcite > flake8: F401 'tests.common.skip.SkipIf' imported but unused Done -- To view, visit http://gerrit.cloudera.org:8080/24075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cc0982fe2ece5323cfc77ee8aee4c55bac6062f Gerrit-Change-Number: 24075 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:51:06 +0000 Gerrit-HasComments: Yes
