Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/24041 )
Change subject: IMPALA-14583: Support partial RPC dispatch for Iceberg tables
......................................................................
Patch Set 5: Code-Review+2
>The SoftReference seems a good fit. I'm a bit confused though that I can't
>find it anywhere else in the entire project.
good question why we don't use it more often - it is a legit tool for the case
of "keeping this in memory saves time, but can be recreated if needed", and
seems much more reliable than the current logic in catalogd to invalidate
tables on mem pressure("invalidate_tables_on_memory_pressure"). Coordinators
have a more sophisticated tool (size bounded guava cache).
upgrading to +2
--
To view, visit http://gerrit.cloudera.org:8080/24041
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f2c058b7cc8efc15bac9fe0e91baadbb7b92cbb
Gerrit-Change-Number: 24041
Gerrit-PatchSet: 5
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Sat, 21 Mar 2026 09:17:37 +0000
Gerrit-HasComments: No
