Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24041 )
Change subject: IMPALA-14583: Support partial RPC dispatch for Iceberg tables ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/24041/3/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@162 PS3, Line 162: : // Fast path: if requesting the entire container, use toThrift() directly : if (startOffset == 0 && endOffset == fileDescList_.size()) return toThrift(); : > Adding some more backlash for the reverse map :) A hash map should take aro A bit late, but I think I found a way to make this fast without any memory overhead. We could merge this as it is from my side and maybe implement the optimization in another patch. The idea is to change MapListContainer's fileDescMap_ to contain integer offsets to fileDescList_ instead of references to the same object. This would allow simple pagination by going through fileDescList_.entries() and include every entry where the offset is in the desired range. Memory usage would be lower or the same depending on the JVM using 4 or 8 byte references. The only cost is that looking up EncodedFileDescriptor's from fileDescMap_ would need an extra get from an array. -- To view, visit http://gerrit.cloudera.org:8080/24041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f2c058b7cc8efc15bac9fe0e91baadbb7b92cbb Gerrit-Change-Number: 24041 Gerrit-PatchSet: 5 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 12 Mar 2026 13:45:05 +0000 Gerrit-HasComments: Yes
