Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@299 PS14, Line 299: if (queryId != null) { : catalogResetMetadata > nit: this can be removed Done http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@341 PS14, Line 341: catalogFinalizeDmlCounter_.incrementOperation(req); : } > nit: this can be removed as well Done http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/service/JniCatalog.java@342 PS14, Line 342: ) { > nit: to be consistent with updateCatalog(), we can remove this "result.leng Done http://gerrit.cloudera.org:8080/#/c/23811/14/fe/src/main/java/org/apache/impala/service/JniCatalog.java@373 PS14, Line 373: ) { > nit: same here, we can remove "result.length > 0" Done -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 15 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 08:57:18 +0000 Gerrit-HasComments: Yes
