Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23889 )
Change subject: IMPALA-12027: Support additional details for DataSink nodes in ExecSummary ...................................................................... Patch Set 6: Code-Review+1 (5 comments) Looks good overall, left just a few nits http://gerrit.cloudera.org:8080/#/c/23889/6/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java File fe/src/main/java/org/apache/impala/planner/MultiDataSink.java: http://gerrit.cloudera.org:8080/#/c/23889/6/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java@21 PS6, Line 21: import java.util.HashSet; unused import http://gerrit.cloudera.org:8080/#/c/23889/6/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java@23 PS6, Line 23: import java.util.Set; unused import http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py@289 PS6, Line 289: query = "create table if not exists %s.iceberg_test stored as iceberg "\ : % unique_database + "as select * from functional_parquet.iceberg_v2_no_deletes "\ : "tblproperties('format-version'='2');" : handle = self.execute_query(query) This CTAS statement will have an insert sink, which we could also test that it has the label detail. http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py@304 PS6, Line 304: writtent nit: typo http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py@305 PS6, Line 305: assert "%s.iceberg_test" % unique_database in exec_summary, \ : "Table details for 'SINK NODE' are missing in the ExecSummary :\n" + exec_summary Could you please assert that the table name is displayed for the sink and not the scan? -- To view, visit http://gerrit.cloudera.org:8080/23889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2652dd896f72c5c6bbe7e76facdede2a237808d5 Gerrit-Change-Number: 23889 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 10:06:37 +0000 Gerrit-HasComments: Yes
