Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23889 )
Change subject: IMPALA-12027: Support additional details for DataSink nodes in ExecSummary ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23889/8/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23889/8/tests/query_test/test_observability.py@292 PS8, Line 292: profile = self.execute_query(query).runtime_profile : exec_summary = re.search(r"ExecSummary:(.*?)Errors", profile, re.DOTALL).group(1) Nit: You can get a structured version of the exec summary when using self.client.execute(query, fetch_exec_summary=True). See how test_scan_summary() and test_sink_summary() above use that to check the operator and detail fields. It may require some searching through the exec summary to find the right nodes. Using that method can avoid a bunch of regexes. -- To view, visit http://gerrit.cloudera.org:8080/23889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2652dd896f72c5c6bbe7e76facdede2a237808d5 Gerrit-Change-Number: 23889 Gerrit-PatchSet: 8 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 20:39:43 +0000 Gerrit-HasComments: Yes
