Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23889 )
Change subject: IMPALA-12027: Support additional details for DataSink nodes in ExecSummary ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23889/6/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java File fe/src/main/java/org/apache/impala/planner/MultiDataSink.java: http://gerrit.cloudera.org:8080/#/c/23889/6/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java@32 PS6, Line 32: import hiveexec.com.google.common.base.Preconditions; Use com.google.common.base.Preconditions (The "hiveexec" version is from a shaded Hive jar. Sometimes IDEs get confused and import a shaded version of a package.) http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23889/6/tests/query_test/test_observability.py@a278 PS6, Line 278: Is it intentional to remove this line? If so, why remove it? -- To view, visit http://gerrit.cloudera.org:8080/23889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2652dd896f72c5c6bbe7e76facdede2a237808d5 Gerrit-Change-Number: 23889 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 13 May 2026 00:12:59 +0000 Gerrit-HasComments: Yes
