Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 5: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction-test.cc File be/src/service/query-profile-redaction-test.cc: http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction-test.cc@124 PS5, Line 124: "value": "select decoy_table_002.id from decoy_table_002 join original_target on decoy_table_002.id = original_target.id" line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@75 PS5, Line 75: R"(\b(?:(?:25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\.){3}(?:25[0-5]|2[0-4]\d|1\d\d|[1-9]?\d)\b)", line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@303 PS5, Line 303: static const unordered_set<string> HOST_SECTION_KEYS = {"Per Host Min Memory Reservation"}; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@309 PS5, Line 309: for (std::sregex_iterator it(section.cbegin(), section.cend(), HOST_WITH_PORT_RE), end; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@344 PS5, Line 344: if (last_dot == string_view::npos || last_dot == 0 || last_dot + 1 >= fq.size()) continue; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@414 PS5, Line 414: redacted = BuildApplyAndTrackAliases(username_tokens, "user", redacted, alias_to_original); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@421 PS5, Line 421: redacted = BuildApplyAndTrackAliases(table_tokens, "table", redacted, alias_to_original); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24282/5/be/src/service/query-profile-redaction.cc@422 PS5, Line 422: redacted = BuildApplyAndTrackAliases(column_tokens, "column", redacted, alias_to_original); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 5 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 20:11:18 +0000 Gerrit-HasComments: Yes
