Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/24282 )
Change subject: IMPALA-14961: Query Profile Redaction ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc File be/src/service/query-profile-redaction.cc: http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@115 PS11, Line 115: unordered_set<string> seen_matches; use unordered_set<string_view> instead since you're just using it for comparison in local scope. ``` ... string_view token(match[group_index].first, match[group_index].second); if (!seen_matches.insert(token).second) continue; results.emplace_back(token.begin(), token.end()); ... ``` http://gerrit.cloudera.org:8080/#/c/24282/11/be/src/service/query-profile-redaction.cc@137 PS11, Line 137: unordered_set<string> seen_matches; Use unordered_set<string_view> to avoid unnecessary copies. ``` ... string_view candidate(text.data() + start, pos - start); ... results.emplace_back(candidate); ... ``` -- To view, visit http://gerrit.cloudera.org:8080/24282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c5b4911a64888f319f212155df6e08c1800b32 Gerrit-Change-Number: 24282 Gerrit-PatchSet: 11 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 16 May 2026 00:11:41 +0000 Gerrit-HasComments: Yes
